Hi, On Tue, Aug 23, 2016 at 03:49:55PM +0200, Gert Doering wrote: > David, please revert both release/2.3 and master, and we'll need to > rethink this, not using "is_ipv4()"...
Ow, ow, this patch is not good...
Turns out it also breaks p2p mode...
Tue Aug 23 21:28:07 2016 us=528530 UDP link local (bound):
[AF_INET][undef]:51198
Tue Aug 23 21:28:07 2016 us=528539 UDP link remote: [AF_INET][undef]:51198
Tue Aug 23 21:28:07 2016 us=528612 TIMER: coarse timer wakeup 1 seconds
Tue Aug 23 21:28:07 2016 us=529094 RANDOM USEC=205433
Tue Aug 23 21:28:07 2016 us=529128 PO_CTL rwflags=0x0001 ev=5 arg=0x006a5ee8
Tue Aug 23 21:28:07 2016 us=529137 PO_CTL rwflags=0x0001 ev=4 arg=0x006a5824
Tue Aug 23 21:28:07 2016 us=529147 I/O WAIT TR|Tw|SR|Sw [1/205433]
Tue Aug 23 21:28:07 2016 us=529958 PO_WAIT[1,0] fd=4 rev=0x00000001
rwflags=0x0001 arg=0x006a5824
Tue Aug 23 21:28:07 2016 us=529976 event_wait returned 1
Tue Aug 23 21:28:07 2016 us=529984 I/O WAIT status=0x0004
Tue Aug 23 21:28:07 2016 us=530017 read from TUN/TAP returned 76
Tue Aug 23 21:28:07 2016 us=530028 TUN READ [76]
Memory fault
... because it unconditionally checks
1005 drop_if_recursive_routing (struct context *c, struct buffer *buf)
1006 {
1007 bool drop = false;
1008 struct openvpn_sockaddr tun_sa = c->c2.to_link_addr->dest;
... which is a NULL ptr dereference here...
(gdb) print c->c2.to_link_addr
$7 = (struct link_socket_actual *) 0x0
(tun interface comes up, operating system wants to send something, most
likely IPv6 DAD or the likes, which won't go out due to "no remote yet",
but still enters here, and *blam*)
Needs more thorough testing... I'll put the next version into my treadmill
of "all possible weird ways to hook stuff together" (p2p, --inetd, ...)
and that will hopefully find all issues before pushing it out.
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
