On Fri, Aug 26, 2016 at 1:48 PM, David Sommerseth <dav...@openvpn.net>
wrote:
> This is will provide an interface for other mechanisms to be used to
> query the user for information, such as usernames, passwords, etc.
>
> It has also been a goal to make it possible to query for all the
> information in one call and not do it sequencially as before.
>
> [v5 - Ensure password prompt is only displayed if we should read
> from stdin ]
>
> [v4 - add a simple wrapper combining query_user_{init,add,exec}()
> - change disapproved &= syntax ]
>
> [v3 - Avoid the dynamic list, use a static list of QUERY_USER_NUMSLOTS
> - The list of query_user data is now a global variable
> - Replaced query_user_init() with query_user_clear()
> - Make query_user_add() a void function
> - Rebased against master/600dd9a16fc61 ]
>
> [v2 - Removed the QUERY_USER_FOREACH macro
> - Avoided using underscore prefix in function names
> - Make query_user_init() do M_FATAL and become a void function
> instead of returning false in these unlikely situations ]
>
> Signed-off-by: David Sommerseth <dav...@openvpn.net>
> ---
> src/openvpn/Makefile.am | 2 +-
> src/openvpn/console.c | 228 +++++-------------------------------
> src/openvpn/console.h | 89 +++++++++++++-
> src/openvpn/console_builtin.c | 261 ++++++++++++++++++++++++++++++
> ++++++++++++
> src/openvpn/misc.c | 61 +++++++---
> src/openvpn/pkcs11.c | 7 +-
> 6 files changed, 423 insertions(+), 225 deletions(-)
v5 looks good.
ACK (only for git-master).
I still think username, password and static challenge should be combined
into one query_user_exec() call but no need to hold this back for that.
Selva
------------------------------------------------------------------------------
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
