On 30 August 2016 at 00:41, David Sommerseth <open...@sf.lists.topphemmelig.net> wrote: > Just some more benchmarks. I just compiled successfully with -std=c99 > on an old Scientific Linux 6.5 (RHEL 6.5 clone) I found. Another > important detail, RHEL5 will reach the "End of Production" phase March > 2017, OpenVPN have generally stopped supporting the oldest RHEL > releases once it hits EOL. RHEL 5 subscribers may purchase an > extended life cycle, but we have not cared too much about that so far. > > > There is one detail though regarding the patch itself. Your patch > adds -std=c99 to the CFLAGS quite early. The compile line gets quite > interesting if you try to swap this setting by using the recommended > approach: > > ./configure CFLAGS="$CFLAGS -std=gnu89" > > Doing this results in the command line being run during compilation to > be be: gcc -std=gnu89 .... -std=c99 ... > > So the -std argument appears twice. This should probably be avoided.
Hm, good point. But I don't think settings CFLAGS="something" should overwrite *all* our default CFLAGS (I know there are currently none, but I'd love to add extra warning flags to the defaults in the future). We could do something like we did for the deps, i.e. add a CFLAGS_STD that defaults to (.e.g.) -std=c99. -Steffan ------------------------------------------------------------------------------ _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
