PUSH_DEFINED is currently unused, so overall I don't have any problem with this. Probably when something gets written that needs PUSH_DEFINED, the subtletes of how it should operate will become more apparent.
James Neil Brown <ne...@cse.unsw.edu.au> said: > > This patch is of little import, but I thought I would submit it > anyway. > > openvpn has a "PUSH_DEFINED" macro which is used to determine how the > configuration summary, which is exchanged for consistency checking, is > created. > > PUSH_DEFINE should be equivalent to "something might get pushed". It > is currently true iff push_list is non-NULL. However there is another > case when things are pushed. i.e. if ifconfig_pool is defined. > So this patch corrects PUSH_DEFINED. > > Thanks, > NeilBrown > > > ### Diffstat output > ./options.h | 2 +- > 1 files changed, 1 insertion(+), 1 deletion(-) > > diff ./options.h~current~ ./options.h > --- ./options.h~current~ 2004-07-27 11:44:12.000000000 +1000 > +++ ./options.h 2004-07-27 11:44:12.000000000 +1000 > @@ -340,7 +340,7 @@ struct options > > #if P2MP > #define PULL_DEFINED(opt) ((opt)->pull) > -#define PUSH_DEFINED(opt) ((opt)->push_list) > +#define PUSH_DEFINED(opt) ((opt)->push_list || (opt)->ifconfig_pool_defined) > #else > #define PULL_DEFINED(opt) (false) > #define PUSH_DEFINED(opt) (false) > --
