Mathias Sundman <math...@nilings.se> said:

> --- forward-orig.c      Fri Jul 30 22:08:22 2004
> +++ forward.c   Sun Aug  8 09:48:21 2004
> @@ -243,6 +243,7 @@
>         update_time ();
>         event_timeout_clear (&c->c2.route_wakeup);
>         event_timeout_clear (&c->c2.route_wakeup_expire);
> +      msg (M_INFO, "Finished adding routes to system.");
>       }
>     else
>       {
> 
> 
> James, could you include this in next beta?

Yes, this is fine.  Regarding the details:

* I take it that you are using the M_INFO message level so you can be sure the
message will be in the log.  Normally I would want to use something like
D_ROUTE for this.  And even if M_INFO is used, it can still be silenced with
--verb 0.

* As is, the patch will cause the message to go to the log, even if there are
no routes to add.  In such a case, the message will be output showing the
point in time at which routes would have been added, had they been present in
the config.  So maybe the message should read differently, such as "TUN/TAP
interface up".

* The message will only be output if c->options.route_delay_defined is true. 
On Windows, this is always the case, so that's probably what you want.

James


Reply via email to