It's not so simple -- the "mtu-dynamic" string is passed across the network which means the patch below will break backward compatibility when one side of the connection is patched but the other side is not. In fact, that's the reason why the options consistency protocol still uses "mtu-dynamic" instead of "fragment". The solution that preserves backward compatibility is to continue using "mtu-dynamic", but do a search/replace of "mtu-dynamic" -> "fragment" on the warning string before it is output.

Actually if that's the worst bug you guys can find, we're probably ready to release 2.1 :)

James

David Sommerseth wrote:
I'm guessing the following patch would correct this ....


--- options.c.orig      2008-09-08 08:32:05.000000000 +0200
+++ options.c   2008-09-08 08:31:10.000000000 +0200
@@ -2236,7 +2236,7 @@

 #ifdef ENABLE_FRAGMENT
   if (o->fragment)
-    buf_printf (&out, ",mtu-dynamic");
+    buf_printf (&out, ",fragment");
 #endif

 #ifdef USE_CRYPTO


Seems to me like it's just a typo when preparing the argument parsing.


kind regards,

David Sommerseth




Dave wrote:
..
Hi,

When makins some inconsistency mistake with "--fragment" settings, I get an error message like:

WARNING: 'mtu-dynamic' is present in local config but missing in remote config, local='mtu-dynamic'

I guess this message has to be updates, as "--fragment" is meant to replace "--mtu-dynamic" AFAICS.

This is with 2.1_rc9.
...

Nice bug!  --mtu-dynamic is an ancient option, it was dropped in version 1.5
about 5 years ago.


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to