-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 15/11/10 16:05, Peter Stuge wrote: > Gert Doering wrote: >>> - snprintf (to_send, sizeof (to_send), "\x01%c%s%c%s", >>> strlen(creds.username), >>> - creds.username, strlen(creds.password), creds.password); >>> + snprintf (to_send, sizeof (to_send), "\x01%c%s%c%s", (int) >>> strlen(creds.username) & 0xff, >>> + creds.username, (int) strlen(creds.password) & 0xff, >>> creds.password); >> >> I tend to NAK this. > > I agree. My ack is only for the other patches. (Sorry, I should have > written that in the other mail.) A better solution for this should be > simple as Gert outlined.
I didn't think about this when I wrote this patch, but I completely agree! I'll improve that part. It's also silly to truncate the %c part and not limit the %s as %.255s in this case. Thanks for catching that, I'll send a new patch fixing this one! kind regards, David Sommerseth -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkzhlJwACgkQDC186MBRfrpaPQCePSJrLAyNOysVGjG33NEGl46L qG4An3npEuIjRry2EO+dfRnCO1BfiEuN =dv5a -----END PGP SIGNATURE-----
