On Sunday 07 August 2011 13:08:22 Bertrand Jacquin wrote:
> +1 VERSIONINFO

Could use VS_VERSION_INFO instead of 1

> +  FILEVERSION    _VERSION_
> +  PRODUCTVERSION _VERSION_

See my other mail about the version.

> +    BLOCK "040904b0"  /* en_US, Unicode */

Openvpn itself is not compiled as Unicode binary, so 04090000 for ASCII would 
be more precise.

> +      VALUE "CompanyName",      PACKAGE_NAME "\0"
> +      VALUE "FileDescription",  PACKAGE_NAME "\0"
> +      VALUE "FileVersion",      PACKAGE_VERSION "\0"
> +      VALUE "InternalName",     PACKAGE_TARNAME "\0"
> +      VALUE "OriginalFilename", PACKAGE_TARNAME ".exe\0"
> +      VALUE "ProductName",      PACKAGE_NAME "\0"
> +      VALUE "ProductVersion",   PACKAGE_VERSION "\0"
> +      VALUE "LegalCopyright",   "(C) 2002-2010 " PACKAGE_NAME "
> Technologies, Inc.\0"

The \0's are not needed here.

> +    VALUE "Translation", 0x409, 0x4b0

Same, no Unicode.

Heiko
-- 
Heiko Hund | Software Engineer | Phone +49-721-25516-237 | Fax -200
Astaro a Sophos Company | Amalienbadstr. 41 Bau 52 | 76227 Karlsruhe | Germany
Commercial Register: Mannheim HRA 702710 | Headquarter Location: Karlsruhe
 
Represented by the General Partner Astaro Verwaltungs GmbH
Amalienbadstraße 41 Bau 52 | 76227 Karlsruhe | Germany 
Commercial Register: Mannheim HRB 708248 | Executive Board: Gert Hansen,
Markus Hennig, Jan Hichert, Günter Junk, Dr. Frank Nellissen



Reply via email to