-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 24/11/11 21:11, Gert Doering wrote:
> Hi,
>
> On Thu, Nov 24, 2011 at 08:51:28PM +0100, Gert Doering wrote:
>> So here's the patch - it compiles (MSVC on Win7), the resulting
>> binary works on WinXP, and it's not too ugly - actually it removes
>> more #ifdef's that it adds...
>>
>> Let me know your comments.
>
> So David found it confusing, and I agree to some extend :-) - it's
> easier to see what is happening if we declare our replacement
> functions as openvpn_inet_ntop() and openvpn_inet_pton() right away,
> instead of having the preprocessor #define rename them on the fly.
>
> new patch.
ACK. Applied to master branch in -testing and -stable.
commit 53fb2c5c465ea97fccdc8be1823fff2616f08b50
Author: Gert Doering <g...@greenie.muc.de>
List-Post: openvpn-devel@lists.sourceforge.net
Date: Thu Nov 24 21:09:36 2011 +0100
work around inet_ntop/inet_pton problems for MSVC builds on WinXP
always use our built-in replacement functions now, even if building
on Win7 (which has inet_ntop/inet_pton in the system libraries) because
the resulting binary will then fail on WinXP.
Signed-off-by: Gert Doering <g...@greenie.muc.de>
Acked-by: David Sommerseth <dav...@redhat.com>
Signed-off-by: David Sommerseth <dav...@redhat.com>
kind regards,
David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk7PwpAACgkQDC186MBRfrrb9ACcCYMVyBpIJUwsF5SzdAUZurpU
KJAAoKayma19gm4jwJgAykjkvXaZX0Tq
=L43N
-----END PGP SIGNATURE-----
