On Thu, Dec 8, 2011 at 1:46 AM, David Sommerseth <dav...@redhat.com> wrote:
>
> This kicks out the openvpn_basename() function from misc.[ch] andputs
> it into compat.[ch]. This is to provide the same functionality on
> platforms not having a native basename() function available.
>
> In addition this patch adds dirname() which commit 0f2bc0dd92f43c91e
> depends. Without dirname(), openvpn won't build in Visual Studio.
>
> Signed-off-by: David Sommerseth <dav...@redhat.com>
Hello David,
The idea of compat.[hc] is to have system compatible layer.
There should be no openvpn specific code in these.
Just alternate implementation of missing functionality.
It should be at the end of the chain in term of linkage.
So the "openvpn_dirbasename" should ether be copied to this file and
declared as static or provide a different simpler approach,
(strrchr('\\') or strrchr('/')).
Regards,
Alon.
