On Thu, Dec 8, 2011 at 1:06 PM, Heiko Hund <heiko.h...@sophos.com> wrote: > On Wednesday 07 December 2011 17:58:51 Heiko Hund wrote: >> This patch makes openvpn read the command line in UCS-2 and convert >> it to UTF-8 internally. Windows stores names in the filesystem in UCS-2. >> When using a paths openvpn converts it from UTF-8 to UCS-2 and uses the >> wide character Windows API function. > > One thing I left out on purpose for now was handling --capath with a Unicode > path. To have that work, openvpn would need to define a custom LOOKUP_METHOD > that is Unicode-safe. The one that is currently used is at [1]. The problem > here is the _stat call that needs to be _wstat. Please let me know if that's > something that should be done or not and I'll provide a patch. > > Heiko > > [1] http://cvs.openssl.org/fileview?f=openssl/crypto/x509/by_dir.c&v=1.32
Personally, I think that you should split this loooong patch into several. Style changes, file io, openssl, etc... For the openssl, I would split each change:dn, files. It would be much easier to review and comment. At first glance, the files are relatively ok. Alon.
