-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 22/01/12 22:41, Gert Doering wrote:
> Hi,
> 
> I run all my cross-platform clients tests via t_client.sh, and a few 
> things started to annoy me:
> 
> - must run "make check" as root (which is problematic for buildbot) -
> just prints "test #4", but doesn't tell me what this particular test 
> is doing ("tcp/tap/ipv4-only").
> 
> So - add a variable that can be used to call sudo, and add another
> set of config variables that will make it print out a user-specified
> title of what it's doing.  Fairly trivial, really, but might be useful
> for someone else as well :-)

Just one comment, please feel free to put such verbose messages directly
in the commit log.  The more verbose they are, the easier it is in the
future to understand what were were thinking when adding these commits.

Anyhow ... ACK!  Applied to master branches on -testing/-stable.

commit 9c6ee9d1ecd85535c5529df1144fb02f613f5134
Author: Gert Doering <g...@greenie.muc.de>
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Sun Jan 22 22:37:25 2012 +0100

    add "print test titles" and "use sudo" functionality to t_client.rc

    Signed-off-by: Gert Doering <g...@greenie.muc.de>
    Acked-by: David Sommerseth <dav...@redhat.com>
    Signed-off-by: David Sommerseth <dav...@redhat.com>


kind regards,

David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk8dJHQACgkQDC186MBRfrqBgwCeMVXsQW7uMbU9g4Jrjm4QfbLZ
iTkAoJYuntv7qjAGJsf0jas8cvrpodlA
=tM9Q
-----END PGP SIGNATURE-----

Reply via email to