On Wed, Jan 25, 2012 at 5:18 PM, Gert Doering <g...@greenie.muc.de> wrote: >> If so, shouldn't patches that >> change the interface include appropriate changes to the man page? > > ... and so does the patch. At least my copy of it had a section starting > with
My apologies. I didn't connect that part of the patch with the man page. However, it looks the patch only adds an entry for the _script_ to the "Script Order of Execution" section. The description of the _option_ that sets up the script to be executed, the "--route-pre-down" option, that appears in the patch for options.c only affects the usage message, not the man page. I think that description (or something similar) should also be included in the man page (i.e., in openvpn.8). Also, it might help to clarify that the script is called before anything at all is done about the disconnection (which I assume is true). In other words, that the route teardown is the first step in the disconnection process. But if that's covered elsewhere I apologize (again!). And maybe the copyright notice in openvpn.8 should be updated, too? Sorry to be a pest if I am still off base.
