Thanks!

Well, i'm no OpenWRT developer, just customizing some packages for my needs,
but i thought that they are sending patches upstream :)

Anyway, if i happen to find anything, i'll post here.

What's for the second patch (gateway/debug stuff), it has been patched in OpenWRT too,
i just forgot to mention it:
https://dev.openwrt.org/browser/packages/net/openvpn-polarssl/patches/400-fix-undefined-print_default.gateway.patch

On Mon, 13 Feb 2012 16:07:04 +0100, David Sommerseth wrote:
On 13/02/12 14:00, Igor Novgorodov wrote:
I'm building latest GIT with:

./configure \
--disable-debug \
--disable-plugins \
--disable-management \
--disable-socks \
--disable-password-save \
--disable-multi \
--disable-server \
--disable-pkcs11 \
--disable-http \
--disable-port-share \
--disable-def-auth \
--disable-pf \
--disable-lzo \
--disable-selinux \
--disable-iproute2 \
--enable-small

(effectively, the version that supports only static keys and no fancy stuff)

Build fails with:
...
gcc -DHAVE_CONFIG_H -I. -I. -g -O2 -MT init.o -MD -MP -MF .deps/init.Tpo
-c -o init.o init.c
init.c: In function ‘do_route’:
init.c:1364:7: error: too few arguments to function ‘plugin_call’
plugin.h:196:1: note: declared here
init.c: In function ‘do_init_crypto_tls’:
init.c:2286:20: error: ‘const struct options’ has no member named ‘sc_info’
make[2]: *** [init.o] Error 1
...

Here are even two errors, one of which (plugin_call) function is
addressed in OpenWRT patchset:

https://dev.openwrt.org/browser/packages/net/openvpn-polarssl/patches/300-fix-plugin_call-with-ssl.patch

I would love the OpenWRT guys o give us a heads up directly when something
like this is noticed.  Such things we really want to fix ASAP.




However, I didn't particular like the approach in that patch, so I've
attached another patch for review. If this is acked, please consider using
this one instead (patch 0001).

And another is that i'm talking about.

I'm giving your patch an ACK, so that will go into the tree. But even one
more fix is needed, which is in the second patch I attached.


kind regards,

David Sommerseth


On 13.02.2012 16:32, David Sommerseth wrote:
On 12/02/12 19:40, i...@novg.net wrote:
When building a very minimal OpenVPN for OpenWRT with
--disable-management among others, the compilaton fails due to
ENABLE_CLIENT_CR being defined, although the management interface,
which makes use of it, has been disabled.

The attached simple patch checks for ENABLE_MANAGEMENT before defining
ENABLE_CLIENT_CR.
Which version are you compiling? I tried a couple of compile with the
latest version in git (master branch) in combination with
--disable-management and --enable-small ... And I could not manage to
trigger this one.  Our buildbot (even though, not testing all
combinations) have also not triggered this one.

Could you provide more version information and the configure arguments
you use?


kind regards,

David Sommerseth




------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel


Reply via email to