On Wed, Mar 28, 2012 at 11:45 AM, David Sommerseth <openvpn.l...@topphemmelig.net> wrote: > The reason for that review is that I'm not convinced adding our own > boolean type is the way to go. I'd much rather see us using stdbool.h > and keep using the bool for pure boolean purposes. Where flags needs to > be used, it makes much more sense to either use a uint type, or maybe > even typedef a flag_t type.
I usually try to avoid as much as possible the stdbool in C. It does not worth the effort, and people tend to misuse it in various of ways, for example storing structure with bool as a member. As bool is not properly defined, I recommend of own bool type that will behave the same in all platforms. Alon.
