-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/05/12 19:54, David Sommerseth wrote:
> To avoid confusion between check_file_access() and
> check_cmd_access() in the future, remove unneeded arguments from
> check_cmd_access()
>
> As a command will always be a file, it should always check for
> CHKACC_FILE and nothing else. And as the commands always will need
> X_OK, check only for that.
>
> One change from earlier behaviour is that R_OK is not checked for.
> The reason is that only scripts require R_OK to work. However, a
> system might be installed with binaries with only X_OK set. If a
> script is missing R_OK, then the execution will fail due to lacking
> permissions.
>
> Signed-off-by: David Sommerseth <dav...@redhat.com> ---
> src/openvpn/options.c | 48
> ++++++++++++++++++++++++++---------------------- 1 files changed,
> 26 insertions(+), 22 deletions(-)
Applied to master branches on -testing and -stable trees.
commit 0576a9f2f8c8a7cf2d50579e6762df6c86b388c5
Author: David Sommerseth <dav...@redhat.com>
List-Post: openvpn-devel@lists.sourceforge.net
Date: Wed May 2 19:54:12 2012 +0200
Simplify check_cmd_access() function
Signed-off-by: David Sommerseth <dav...@redhat.com>
Acked-by: Alon Bar-Lev <alon.bar...@gmail.com>
Message-Id: 1335981252-7390-1-git-send-email-dav...@redhat.com
URL: http://article.gmane.org/gmane.network.openvpn.devel/6391
kind regards,
David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk+iNbgACgkQDC186MBRfrqS+QCgjAEP5G6I4ZuPIENYMZXSxMoo
3UQAn2jZpM5ufBNPimZLvd/XV5ahbKeI
=Xyxv
-----END PGP SIGNATURE-----
