Hi Alon On Thursday 02 August 2012 20:20:45 Alon Bar-Lev wrote: > Thanks, although I think the extra macro is not required.
It looked messy without it. That's why we have it. > Last thing I see is that you need to #include <stdarg.h> as va_list is used. It's included already. > And last style comment, I don't think use of enum for bit fields is > common, better to simply #define the constants. I try to prefer enums over the preprocessor whenever I can. I like that there is a type that you can look up, even if it's not worth much besides that. Heiko -- Heiko Hund | Sr. Software Engineer | Tel +49-721-25516-237 | Fax -200 SOPHOS NSG | Amalienbadstr. 41 Bau 52 | 76227 Karlsruhe | Germany
