Hi, On Tue, Aug 07, 2012 at 12:03:57PM +0200, Arne Schwabe wrote: > the getaddr6 and getaddr_mutli functions are duplicates of each other. Since > we always require getaddrinfo to be present both function are merge into one > openvpn_getaddrinfo. > > This functions also returns a standard struct addrinfo* so our resolve > interface is closer to the standard unix interface. The getaddr function is a > wrapper which provides backward compatibility for IPv4 addresses. Ipv6 calls > and calls to getaddr_multi are replaced with the new interface.
So. I tested this already when you posted it (and it passes all my
t_client tests, connecting to IPv4 and IPv6 hosts, and inserting lots of
IPv4 routes - none of them to-be-resolved, though, but given the problems
with route duplication in v3, I assume it will do).
Today I went there and reviewed all of the code, and tried in earnest to
understand what happens where :-)
I ACK this, but please remember to tell your editor to use 8-character tabs,
as that is "what the rest of the code uses" - some of the new code looks
quite weird with ":set ts=8", and there's more diffs in there due to
whitespace changes (4 spaces getting converted into a single tab, like
before 'hostname = "::"'). We do not need a v5 re-spin, as David said
he'll take care of these.
(Samuli: we need a style guide in the wiki...)
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
pgpGsmrLMXMgM.pgp
Description: PGP signature
