On 01/10/12 20:47, Kenneth Rose wrote: > There's a small implementation issue with the V3 plugin API > implementation. V3 plugins cannot return data back to OpenVPN using > openvpn_plugin_args_func_return since > openvpn_plugin_args_func_return.return_list is always NULL. > > This patch makes the behaviour identical to the V2 API (return_list is > again a proper out parameter). > > Signed-off-by: Kenneth Rose <ken+open...@surfeasy.com> > --- > src/openvpn/plugin.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) >
Thanks a lot for catching this one! I've ran some test code to verify this fix
as well, and it looks good so ...
ACK. Applied to master and beta/2.3 branches.
commit e92255f58bcfaec157c3ef59e01c40cbd04b1d43 (master)
commit aa1a1d91ca1266342762460f86427a577b51908f (beta/2.3)
Author: Kenneth Rose <ken+open...@surfeasy.com>
List-Post: openvpn-devel@lists.sourceforge.net
Date: Mon Oct 1 14:47:02 2012 -0400
Fix v3 plugins to support returning values back to OpenVPN.
Signed-off-by: Kenneth Rose <ken+open...@surfeasy.com>
Acked-by: David Sommerseth <dav...@redhat.com>
Message-Id:
CAAUdgR8VZjaO0-thFPVoQkbZ1DNG3rx+gtYYLqyfocp3yns==w...@mail.gmail.com
URL: http://article.gmane.org/gmane.network.openvpn.devel/7083
Signed-off-by: David Sommerseth <dav...@redhat.com>
kind regards,
David Sommerseth
signature.asc
Description: OpenPGP digital signature
