Re: [Openvpn-devel] [PATCH 5/5] Emulate persist-tun on Android

[Arne Schwabe]

Am 25.04.13 20:58, schrieb Gert Doering:

Hi,

On Sat, Apr 20, 2013 at 04:22:48PM +0200, Arne Schwabe wrote:

On Android changing the configuration of tun is not possible. So instead of 
reconfiguring the tun device, open a new tun device and close the old one if 
needed

I'm not sure I like this patch.  Wouldn't it be easier to tackle this
in options.c with an

#ifdef TARGET_ANDROID
     msg(M_WARN, "notice: android cannot do --persist-tun, ignoring statement");
#else
     ... old code here
#endif

(if you have to reopen the tun anyway) - or does persist-tun have other
side effects that I'm overlooking?

Yes. Without persist-tun openvpn will close on disconnect and open tun on reconnect, i.e. allowing traffic to pass over the unecrypted channel. With persist-tun tun will be kept open and not allowing traffic to pass. Reconfiguring the interface on Android has be done by the close/open tun dance this patch does.

Arne

smime.p7s
Description: S/MIME Kryptografische Unterschrift