guys, please pay attention to this message. it really resolves issue with openvpn on windows 8.1
---------- Forwarded message ---------- From: Илья Шипицин <chipits...@gmail.com> List-Post: openvpn-devel@lists.sourceforge.net Date: 2013/12/4 Subject: uninitialized handle fix (serious issue on Win 8.1) To: "openvpn-devel@lists.sourceforge.net" <openvpn-devel@lists.sourceforge.net> Hello! I confirm issue described here: https://forums.openvpn.net/topic13246.html also, I confirm that it is due to random handle value (which somehow was null before Win 8.1 was released) also, I do not understand why we should check "err" handle on INVALID_HANDLE_VALUE, it will fail anyway on WriteFile, that check is useless. I do not insist on being perfect, if someone has better idea how to solve https://forums.openvpn.net/topic13246.html - I do not mind. I can make git pull request from https://github.com/chipitsine/openvpn/commit/3987bd0e035b653a5017c5eccbd54eaf22746852 if it's better. people encounter problems on Win 8.1 (well, just couple of people here, we are running openvpn with tens of customers on Win 8.1), I beleive it is serious issue, please consider release of openvpn. diff --git a/src/openvpn/console.c b/src/openvpn/console.c index afda8ca..3ec5758 100644 --- a/src/openvpn/console.c +++ b/src/openvpn/console.c @@ -62,7 +62,6 @@ get_console_input_win32 (const char *prompt, const bool echo, char *input, const err = get_orig_stderr (); if (in != INVALID_HANDLE_VALUE - && err != INVALID_HANDLE_VALUE && !win32_service_interrupt (&win32_signal) && WriteFile (err, prompt, strlen (prompt), &len, NULL)) { diff --git a/src/openvpn/error.c b/src/openvpn/error.c index 6848425..acc7977 100644 --- a/src/openvpn/error.c +++ b/src/openvpn/error.c @@ -454,12 +454,12 @@ close_syslog () #ifdef WIN32 -static HANDLE orig_stderr; +static HANDLE orig_stderr = INVALID_HANDLE_VALUE; HANDLE get_orig_stderr (void) { - if (orig_stderr) + if (orig_stderr != INVALID_HANDLE_VALUE) return orig_stderr; else return GetStdHandle (STD_ERROR_HANDLE);
