On 21/04/2014 05:27, Arne Schwabe wrote:
On 21.04.2014 09:10, James Yonan wrote:
Define PIP_OPT_MASK to represent all flags of interest to
process_ip_header, so that it can have a fast exit path
if no flags are set.
I haven't look at the code but if remember correctly, this method does
not get passed the actual flags but the flags should *potientially* be
checked.
Yes, the point is to aggregate the potential flags of interest to
process_ip_header under a single mask, i.e. PIP_OPT_MASK.
So instead of having "if (flags & (PIPV4_PASSTOS|PIP_MSSFIX|...|...))"
you just have "if (flags & PIP_OPT_MASK)".
The main issue for us is that we have an internal patch for one of our
services that adds an additional flag, and the previous usage is a merge
conflict attractor because all the flags of interest are explicitly
given on a single line.
See also my never reviewed patch:
http://thread.gmane.org/gmane.network.openvpn.devel/7532
Your patch would be simplified with this approach because you don't need
to add the test for PIPV4_CLIENT_NAT to "if (flags & ...)".
James
