ACK
Getting rid of useless log messages makes the important ones stand out
more, which is great.
Maybe put the IPv6 link-local address comment on a single line?
-Steffan
On 06-06-14 20:43, Gert Doering wrote:
> IPv6 has the concept of "link local" addresses, fe80::<host id>, which
> normally are present on every link, and are used for stuff like DHCPv6,
> neighbor discovery, etc.
>
> OpenVPN point-to-multipoint mode currently does neither configure them on
> tun interfaces, nor are they handled in a meaningful way if a client OS
> always has them (like Windows or Solaris) - so the log fills with many
> lines of "MULTI: bad source address from client [fe80::...]", serving
> no useful purpose.
>
> This patch just recognizes IPv6 LL packets and silently drops them.
>
> Further patches can build on this and add full link-local support, which
> would require address learning (as the addresse are based on host IDs, not
> assigned by the server).
>
> Signed-off-by: Gert Doering <g...@greenie.muc.de>
> ---
> src/openvpn/multi.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c
> index e451924..f00a9cf 100644
> --- a/src/openvpn/multi.c
> +++ b/src/openvpn/multi.c
> @@ -2161,8 +2161,18 @@ multi_process_incoming_link (struct multi_context *m,
> struct multi_instance *ins
> /* make sure that source address is associated with this client */
> else if (multi_get_instance_by_virtual_addr (m, &src, true) !=
> m->pending)
> {
> - msg (D_MULTI_DROPPED, "MULTI: bad source address from client
> [%s], packet dropped",
> - mroute_addr_print (&src, &gc));
> + /* IPv6 link-local address (fe80::xxx)?
> + */
> + if ( (src.type & MR_ADDR_MASK) == MR_ADDR_IPV6 &&
> + src.addr[0] == 0xfe && src.addr[1] == 0x80 )
> + {
> + /* do nothing, for now. TODO: add address learning */
> + }
> + else
> + {
> + msg (D_MULTI_DROPPED, "MULTI: bad source address from
> client [%s], packet dropped",
> + mroute_addr_print (&src, &gc));
> + }
> c->c2.to_tun.len = 0;
> }
> /* client-to-client communication enabled? */
>
