Hi Lev, On 10/21/2014 09:33 AM, Lev Stipakov wrote: > > Thanks for your comments. I have fixed (1) and (2) - well, reusing > existing code in (2) has fixed also (1).
Thanks! Do you have the patch somewhere for us to look at? > Regarding (3) - I don't have much experience in crypto thing, so it > would be nice if someone suggests if we should use another alignment. >From later discussions I get the feeling the alignment was not crypto related. Also, alignment for crypto is very platform-specific. e.g. AES-NI instructions require 128-bit alignment for maximum speed. Though it depends on the crypto mode and implementation whether the data we supply it is directly used or not. The main accelerated crypto mode currently is AES-GCM, and that does not run the data through the crypto (but rather encrypts counters, and then XORs the result with the data). So I wouldn't worry too much about that for now. -Steffan
