From: David Sommerseth <dav...@redhat.com>
In systemd after version 216, systemd-ask-password will support --echo which
will avoid masking the user input. As OpenVPN uses this mechanism collecting
usernames when systemd is available, this will avoid the input of usernames to
be masked.
This patch also adds the --icon argument, which is aimed at graphical inputs.
For example when OpenVPN is started at system boot-time using a graphical boot
interface such as Plymouth.
Signed-off-by: David Sommerseth <dav...@redhat.com>
---
configure.ac | 1 +
src/openvpn/console_systemd.c | 6 ++++++
2 files changed, 7 insertions(+)
diff --git a/configure.ac b/configure.ac
index 0b8e111..6e9f45c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1017,6 +1017,7 @@ if test "$enable_systemd" = "yes" ; then
AC_CHECK_FUNCS([sd_booted], [], [AC_MSG_ERROR([systemd library is missing
sd_booted()])])
OPTIONAL_SYSTEMD_LIBS="${libsystemd_LIBS}"
AC_DEFINE(ENABLE_SYSTEMD, 1, [Enable systemd integration])
+ AC_DEFINE_UNQUOTED(SYSTEMD_VERSION, [`echo ${libsystemd_MODVERSION}`],
[systemd version installed])
LIBS="${saved_LIBS}"
fi
diff --git a/src/openvpn/console_systemd.c b/src/openvpn/console_systemd.c
index 63d0399..9ba582a 100644
--- a/src/openvpn/console_systemd.c
+++ b/src/openvpn/console_systemd.c
@@ -32,6 +32,12 @@ get_console_input_systemd (const char *prompt, const bool
echo, char *input, con
argv_init (&argv);
argv_printf (&argv, SYSTEMD_ASK_PASSWORD_PATH);
+#if SYSTEMD_VERSION > 216
+ if( echo )
+ {
+ argv_printf_cat(&argv, "--echo");
+ }
+#endif
argv_printf_cat (&argv, "%s", prompt);
if ((std_out = openvpn_popen (&argv, NULL)) < 0) {
--
1.8.3.1
