On 24/05/15 21:30, Gert Doering wrote: > Hi, > > somewhere between automake-1.11 and automake-1.14 the default for handling > "make check" changed from "serial-tests" to "parallel-tests" - which > sounds harmless, but has the interesting side effect of hiding the output > of all (potentially parallel-run) test scripts until the summary at the > end, and even then, only printing the summary, not the detail output. > > I can see that this looks much more pretty (and colours, wooh!), but > for my day-to-day regression testing and for analyzing buildbot failures, > this just adds extra steps to figure out what it is doing right now, and > where and why it failed this time - especially in the buildbot case, the > difference is "the reason is right in the mail" vs "I need to login to > the buildbot machine, go to the right build directory (of many), and > grab the log file from there". > > > Fortunately, there is an automake option for this, which I'd propose to > enable... (well hidden inside "info automake-1.14" -> "Options") > > diff --git a/tests/Makefile.am b/tests/Makefile.am > index b7980e0..02fa392 100644 > --- a/tests/Makefile.am > +++ b/tests/Makefile.am > @@ -9,6 +9,8 @@ > # Copyright (C) 2006-2012 Alon Bar-Lev <alon.bar...@gmail.com> > # > > +AUTOMAKE_OPTIONS = serial-tests > + > MAINTAINERCLEANFILES = \ > $(srcdir)/Makefile.in > > > ... which brings back the old behaviour. > > I'm not sure whether it can be passed on an "autoreconf -vif" command > line, and if yes, how, but I presume that really nobody who bothers to > run "make check" will be bothered by the normal test output - and especially > nobody who bothers to set up a t_client.rc test rig in the first place... > > But I'm open for discussion and alternative suggestions on this. >
This makes a lot of sense to me. Our project doesn't really benefit in general of running our tests parallel. This gets an ACK from me. I just tested your change locally, and it seems to work very well. And from what I can grasp from the automake documentation [1], this seems safe for us to do. [1] <https://www.gnu.org/software/automake/manual/html_node/Serial-Test-Harness.html> -- kind regards, David Sommerseth
signature.asc
Description: OpenPGP digital signature
