Hi,
Jan Just Keijser wrote:
Gert Doering wrote:
On Thu, Jul 02, 2015 at 11:56:28AM +0200, Jan Just Keijser wrote:
+ write_dhcp_str (buf, 66, o->tftp, &error);
+ write_dhcp_str (buf, 150, o->tftp, &error);
This does not look safe to me (or I'm overlooking something) - if
o->tftp is not set, it will do "strlen(o->tftp)" inside
write_dhcp_str()...
(And we generally shouldn't set options that we do not have anything
to say for :) ).
I fully agree. Here's v2 with Jonathan's remarks addressed as well.
I just discovered that my patch does not set the (poorly documented)
Cisco TFTP options; I'm working on rev3 which does set them correctly
(at least, Wireshark says I am setting them now correctly). Stay tuned :)
JJK
