On Sun, Jul 26, 2015 at 4:41 PM, David Sommerseth <[email protected]> wrote: > On 26/07/15 13:27, Steffan Karger wrote: >> I was wrong to assume that adding the const qualifier to the pointer-to- >> fixed-size-array contruction used in options_hash_changed_or_zero() was >> allowed. GCC actually warns about this, but I was using clang and clang >> seems to be fine with the contruction. To make GCC happy too, reintroduce >> the md5_digest wrapped struct, and use that when passing around the digest. >> >> Signed-off-by: Steffan Karger <[email protected]> > > On holiday these days, so too lazy to check the git commit log ... but is this > a revert of a single commit? If so, having a reference to that commit would > be beneficial to include in this commit message.
It doesn't really revert a commit, since the commit that introduced this changed a lot more code. But it indeed does make sense to reference it explicitly. Gert, could you include a reference to 827de237860813d2859aaae3aca292d42a9c2a82 in the commit msg? -Steffan
