On Tue, Jul 28, 2015 at 2:17 PM, David Sommerseth <[email protected]> wrote: > On 27/07/15 21:22, Gert Doering wrote: >> Hi, >> >> On Mon, Jul 27, 2015 at 09:02:46PM +0200, Gert Doering wrote: >>> Your patch has been applied to the master branch. >> >> Actually, not... this breaks out of tree builds... >> >> gcc -DHAVE_CONFIG_H -I. -I../../../openvpn/src/openvpn -I../.. >> -I../../../openvpn/include -I../../../openvpn/src/compat -g -O2 -MT >> error.o -MD -MP -MF .deps/error.Tpo -c -o error.o >> ../../../openvpn/src/openvpn/error.c >> In file included from ../../../openvpn/src/openvpn/options.h:39:0, >> from ../../../openvpn/src/openvpn/ssl.h:43, >> from ../../../openvpn/src/openvpn/ps.h:32, >> from ../../../openvpn/src/openvpn/error.c:43: >> ../../../openvpn/src/openvpn/plugin.h:38:28: fatal error: openvpn-plugin.h: >> No such file or directory >> #include "openvpn-plugin.h" >> ^ >> compilation terminated. >> >> >> openvpn-plugin.h is nicely built from openvpn-plugin.h.in, but it is >> built in the *build* tree, and the -I statements above do not look >> there - it would need an "-I../../include" to work... > > Hmmm ... That's surprising, as I'd expect we would have the same troubles also > without these patches - as openvpn-plugin.h isn't really touched.
openvpn-plugin.h changed from 'static in the source tree' to 'generated by autotools' (and thus placed in the build tree). The location in the build tree was not in the include list. >> config.h is built in the root directory of the build tree, so "-I../.." >> catches that. Since we have nothing else in ../../include/, nothing >> adds it to the compile statement (and I'm not overly eager to see it there, >> already quite a bit of stuff on the command line). >> >> So... patches, or revert time? > > I'll do some more investigation and fix this ASAP (at least within this week). Fixes are already applied to the master branch. You can just sit back and relax :) -Steffan
