On 04-08-15 14:53, Gert Doering wrote:
Commit b131c7b974d9d4d3f0 introduced a check to create a meaningful warning if we try to read a password after daemon()izing (by checking whether stdin or stderr is connected to a tty). For some reason this breaks on Windows builds if run under GUI control - but since Windows doesn't have this particular daemon() issue anyway, just #ifndef WIN32 the offending code.Signed-off-by: Gert Doering <g...@greenie.muc.de> --- src/openvpn/misc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/openvpn/misc.c b/src/openvpn/misc.c index 21e54b4..f20d059 100644 --- a/src/openvpn/misc.c +++ b/src/openvpn/misc.c @@ -1088,9 +1088,11 @@ get_user_pass_cr (struct user_pass *up, */ else if (from_stdin) { +#ifndef WIN32 /* did we --daemon'ize before asking for passwords? */ if ( !isatty(0) && !isatty(2) ) { msg(M_FATAL, "neither stdin nor stderr are a tty device, can't ask for %s password. If you used --daemon, you need to use --askpass to make passphrase-protected keys work, and you can not use --auth-nocache.", prefix ); } +#endif #ifdef ENABLE_CLIENT_CR if (auth_challenge && (flags & GET_USER_PASS_DYNAMIC_CHALLENGE))
ACK. Patch looks fine and mattock reported (on IRC) that this indeed fixes the issue on Windows.
-Steffan
