Hi,
>> Requires the installer to update the registry during an upgrade of exisitng
>> installations, or notify the end user of the change in the default value of
>> disconnect_on_suspend (0).
>
> What does this patch *do*? Is this the "set up registry key on first
> start" part (so we set the default differently now)?
>
> But that implies that an upgrade will not change the default, right?
You are right, the current openvpn installer does not rewrite the
registry for the GUI, so an update does not change the default and
that is not good. I left that to the package maintainer with that
comment about the installer and upgrading.
I would have preferred to completely remove the handling of
PBT_APMSUSPEND event in main.c but did not wanted to make pervasive
changes..
Instead, one could just modify openvpn.nsi with an added line in the
GUI install section:
DelRegKeyIfUnchanged HKLM
"SOFTWARE\${PACKAGE_NAME}_GUI}\disconnect_on_suspend" "1"
Selva
