ACK.  It does increase the code slightly (because while the compiler can
optimize away the if() clause in most cases, for each FATAL msg(), the
new exit() leaves a few bytes...) - but the increase is truly marginal
(602843 to 603143 bytes "text segment" on my i386 linux) and it helps
with coverity et al in weeding out false warnings...  certainly useful.

Patch has been applied to the master and release/2.3 branch.

commit 9aebc37c45e440bda5f71b717146b5dc330d5277 (master)
commit 3254099bc4c88315352457b4efb067587df29a77 (release/2.3)

Author: Steffan Karger
List-Post: openvpn-devel@lists.sourceforge.net
Date:   Thu Nov 5 22:03:01 2015 +0100

     Add macro to ensure we exit on fatal errors

     Signed-off-by: Steffan Karger <stef...@karger.me>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <1446757381-27863-1-git-send-email-stef...@karger.me>
     URL: http://article.gmane.org/gmane.network.openvpn.devel/10440
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering


Reply via email to