It's cron2 who wanted clear ifdefs for master, because there's no WinXP support there. I need help with 2.3 build system. While the code itself would compile fine, it won't link because I can't figure out how to link libraries available in vista+ only for vista+ build and do not link it for XP.
On 25.11.2015 03:13, Selva Nair wrote: > Hi, > > On Tue, Nov 24, 2015 at 3:11 PM, Gert Doering <g...@greenie.muc.de > <mailto:g...@greenie.muc.de>> wrote: > > Not sure I understand this. The patch I had tested all along had ifdef > _WINNT_WIN32 >= 0x0600 around everything. So the code nicely silences itself > when > built for XP (I did not try this though). I built only 64 bit version for > vista+. > > And this was against the master. Now the new sets of patches have different > ifdefs: _WINNT_WIN32 >= 0x600 for 2.3, and if defined(WIN32) for master. This > appears unnecessary. Two patches are still needed as some context lines have > changed between 2.3 and master, but the code could be the same, and, in > particular, the ifdefs could be just _WINNT_WIN32 >= 0x600. > > May be you mean the same? > > Selva >
signature.asc
Description: OpenPGP digital signature
