Hi,so, this took quite a while - barely 2.5 years, but we're getting there. v3 of the patch has been rebased to git master, and all comments from Steffan and my earlier review have been integrated into the build stuff and the openvpn side of the code - so, as far as openvpn goes, I'm fine with merging that but would welcome an independent ACK (given that I modified quite a bit of Heiko's code). The service part has been *tested* - as in: - compiles (mingw) - runs on Win7 (openvpnserv -remove, copy in new binary, run "openvpnvserv -install", "openvpnserv -start interactive" [or reboot]) - does what it says on the tin: - run openvpn.exe as the user executing the GUI - handles adding and removing of ipv6 address config and v4/v6 routing - enables use of openvpn gui without [X] admin checkbox as a totally unprivileged user - openvpn log makes it clear whether netsh.exe is used or service what I have not done is a full review of the resulting code - the changes are large and intrusive, and given the amount of code *removal* it looks like "massive cleanup" happened as well. I do not know Windows well enough to understand the intricacies, so a review from someone with a stronger Windows background would be welcome - Selva, are you still around? There are some caveats that need to be tested better in combination with a full reinstall, like "where does the openvpn log go to, and is the destination writeable?" - that seems to relate to registry entries that my system did not have, so there will be extra work for Samuli and Heiko as well... gert
When this code gets into Git "master" the Windows buildslave will start producing installers with this functionality. We can then point people at those. I suspect enterprises in particular are interested in the this functionality so I think we'll get a fair amount of testing before we even reach 2.4.0.
-- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock
