On 08/02/16 17:03, Arne Schwabe wrote: > > > Am 07.02.16 um 20:47 schrieb Steffan Karger: >> This keeps naming consistent. For example, instead of id-aes128-GCM use >> AES-128-GCM, which is more like AES-128-CBC. >> >> + >> + if (NULL == pair) >> + return cipher_name; >> + > I like the pair == NULL style more.
I "kind of" agree, as that's what we've grown up with. However, from a defensive programming style, this is a far better approach. A mistyping using '=' will in 'NULL = pair' case cause a compile failure. The other way around will compile just fine with a nice ugly bug attached with it ... So I'm trying to get used to his "flipped around" style. Especially for OpenVPN, I believe a defensive style is very much appropriate. -- kind regards, David Sommerseth
