Hi, On Fri, Feb 19, 2016 at 01:51:02AM -0500, Selva Nair wrote: > The pacth is in the next email. > > This is not yet tested extensively, but has passed some quick tests. > A simple approach of parsing the options string is used instead of passing > structs: > the latter will break the GUI everytime a new option is added to the > white-list. > > Current white-list is just what the GUI needs, but its easy to extend.
Re-thinking the original argument, I agree that this is easier than
a fixed structure (if only because you'd need to ensure that GUI and
service are talking the same structure version...).
I like what your patch is doing - it's more than "just the whitelist"
but also the administrative restrictions ("if you are not administrator
or part of the OpenVPN Admin group, only configs from a well-known
directory, otherwise, do what you want").
From a C perspective, the code looks good to me.
I'm a bit reluctant to ACK & merge it, I'd like a few more eyes look
on this, from two angles
- is this feature-wise the way we want to go? It "works for me"
- are the windows bits of the code change sane? String manipulation and
wide strings and that stuff is something I have little experience with.
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
