On 25/02/16 13:29, Gert Doering wrote: > Please re-send (and it would be nice if you could do "git commit -s" > for the signed-off-by: - David can explain better what the significance > of that is, but "since we all do it", it's convention)
The reason of adding the Signed-off-by is to have a better understanding of whom have been involved in particular commits/patches. While the "Author field" in the git log (git log --pretty=fuller) can only have one name, more people can have been involved in the patch. Using the Signed-off-by is a way to credit them as well. And when everyone is consistent using the Signed-off-by line, writing tools which parses our git log is also far more easier. The other aspect of the Signed-off-by: line has to do with juridical stuff, to protect the OpenVPN project. By adding the Signed-off-by: line you basically sign-off to "Yes, I am the author of these changes and I am permitted to share them with the project". For more information, these pages explains it even better (same info, two different sources): <https://git.eclipse.org/r/Documentation/user-signedoffby.html> <https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n409> -- kind regards, David Sommerseth
signature.asc
Description: OpenPGP digital signature
