On Wed, May 25, 2016 at 6:12 AM, David Sommerseth <openvpn@sf.lists. topphemmelig.net> wrote:
> On 25/05/16 00:53, Selva Nair wrote: > > Do not mask input when echo is requested. Useful for username > > input and sometimes for challenge response. > > > > Signed-off-by: Selva Nair <selva.n...@gmail.com> > > .. > > Hi Selva, > > Thanks a lot! This patch do make sense, feature wise. And we already > have basically that in a patch queue already. Aha, I did not realize that those patches address the echo issue.. > The problem with this > approach is that it may break systems with systemd older than version 216. > Dud.. I'm more of an irked systemd customer, rather than an aficionado.. > > Gert also requested that this whole interface should be made less "linux > specific" [1], so I started on a patchset which makes the > query-user-input interface far more modular. But I need to get start > hacking on a v4 of that patch set as Gert didn't like several things in > the previous attempt [2]. > > [1] <http://thread.gmane.org/gmane.network.openvpn.devel/9085/focus=9091> > [2] <http://thread.gmane.org/gmane.network.openvpn.devel/10021/> > Well, if a major rewrite of console input is planned, consider replacing getpass() as well. It has arbitrary password length limitations on some platforms. At the same time I'm not sure I understand the need for this overhaul. > > I've just changed employer, and OpenVPN is truly part of what I will be > working on. So getting the query-user-input patches through is high up > on my list. Good to hear. > I just need to get settled with my new employer and I'll > start hacking on it. But your patch is pretty much identical to what > I've already proposed [3]. > > [3] <http://thread.gmane.org/gmane.network.openvpn.devel/10021/focus=10019 > > Your patch has +#if SYSTEMD_VERSION > 216 + if( echo ) + { + argv_printf_cat(&argv, "--echo"); + } +#endif How would such a compile time check be any useful -- the version will have to be checked at run-time, isn't it? So, should I withdraw the patch or try to fix it by hacking up a run-time version check? Selva
