Hi, On Mon, Jun 6, 2016 at 3:05 PM, David Sommerseth < open...@sf.lists.topphemmelig.net> wrote:
> > > IMO, the unit testing patches shouldn't have been merged into the > > release branch > > I did think consider this, but ended up applying them to release/2.3 as > well. My thought is that once we start having more unit tests included, > we should be able to at least add some of those tests to the release/2.3 > branch too. There are code which is refactored so much it won't be easy > to do, but there are also plenty of code which haven't changed that > dramatically. > > I see these first patches from Jens as framework (or infrastructure) > patches, it doesn't mean we commit ourselves to adding unit-testing to > release/2.3, but it gives the possibility to do so. Our 2.3 releases > will continue to live in parallel with the future 2.4 release for quite > some time. I'm of the view that "unit tests" aid development but not much useful for maintenance. So why add unit tests to a stable code-base that should only get bug fixes (i.e., fixes for bugs that show up in real use). On top of that, adding unit tests into an existing code like openvpn will involve a lot of refactoring. The ROI on backporting any such tests to 2.3 does not look worth the effort. Selva
