ACK. Stared at the code, tested, works. I like the way using a linked list actually made this code more simple (which hints that the previous version might not have been ideal, but anyway).
I'm not sure I agree with the style used in apply_pull_filter() - I might have coded it as "first do the strncmp(), and if that matches, use a switch/case block for the rest" (avoid repeating the strnmcp(), and it's actually minimally more effective as the current code always tests the filter type *and* strncmp()'s, while it could skip the filter type on no match) - but that is going very much into personal coding style land. Your patch has been applied to the master branch. commit 7f74c27e105a365d278181d00708c55a299398a0 Author: Selva Nair List-Post: [email protected] Date: Sun Jun 5 17:41:23 2016 -0400 Add an option to filter options received from server Signed-off-by: Selva Nair <[email protected]> Acked-by: Gert Doering <[email protected]> Message-Id: <[email protected]> URL: http://article.gmane.org/gmane.network.openvpn.devel/11808 Signed-off-by: Gert Doering <[email protected]> -- kind regards, Gert Doering
