Hi,

On Sat, Jun 11, 2016 at 04:43:15PM +0200, Arne Schwabe wrote:
> With this change all timeouts before the first packet from the OpenVPN server 
> are unified into the server-poll-timeout option.
> 
> The default of 120s has been chosen to be a safe value is larger as it is 
> larger the sums of the old small timeouts.

One thing I noticed when testing which is not *caused* by this patch but
which you/we might want to fix while at it.

When talking to a "deaf" HTTP proxy - namely, one that accepts the TCP
connect, but then never sends back anything (try 195.30.4.1:23, it's
a "Teergrube" to annoy wannabe hackers) the timeout will fire at the
correct interval - 25s in my test, but then it won't restart but exit:

Sat Jun 11 20:05:59 2016 Attempting to establish TCP connection with 
[AF_INET]195.30.4.1:23 [nonblock]
Sat Jun 11 20:06:00 2016 TCP connection established with [AF_INET]195.30.4.1:23
Sat Jun 11 20:06:00 2016 Send to HTTP proxy: 'CONNECT 10.0.0.1:51196 HTTP/1.0'
Sat Jun 11 20:06:00 2016 Send to HTTP proxy: 'Host: 10.0.0.1'
Sat Jun 11 20:06:24 2016 recv_line: TCP port read timeout expired: Operation 
now in progress (errno=115)
Sat Jun 11 20:06:24 2016 SIGTERM[soft,init_instance] received, process exiting

The same thing happens if I lure openvpn into trying a SOCKS proxy connection
to that host:

Sat Jun 11 20:10:47 2016 Attempting to establish TCP connection with 
[AF_INET]195.30.4.1:23 [nonblock]
Sat Jun 11 20:10:48 2016 TCP connection established with [AF_INET]195.30.4.1:23
Sat Jun 11 20:10:53 2016 socks_handshake: TCP port read timeout expired: 
Operation now in progress (errno=115)
Sat Jun 11 20:10:53 2016 SIGTERM[soft,init_instance] received, process exiting


... while all *other* connection failures I could test trigger a SIGUSR1 
restart...

- plain TCP connection timeout:

Sat Jun 11 20:12:09 2016 Attempting to establish TCP connection with 
[AF_INET]195.30.4.1:20 [nonblock]
Sat Jun 11 20:12:34 2016 TCP: connect to [AF_INET]195.30.4.1:20 failed: 
Connection timed out
Sat Jun 11 20:12:34 2016 SIGUSR1[connection failed(soft),init_instance] 
received, process restarting
Sat Jun 11 20:12:34 2016 Restart pause, 5 second(s)

- TCP connects, but "only dead air":

Sat Jun 11 20:12:48 2016 Attempting to establish TCP connection with 
[AF_INET]195.30.4.1:23 [nonblock]
Sat Jun 11 20:12:49 2016 TCP connection established with [AF_INET]195.30.4.1:23
Sat Jun 11 20:12:49 2016 TCP_CLIENT link local: (not bound)
Sat Jun 11 20:12:49 2016 TCP_CLIENT link remote: [AF_INET]195.30.4.1:23
Sat Jun 11 20:13:14 2016 Server poll timeout, restarting
Sat Jun 11 20:13:14 2016 SIGUSR1[soft,server_poll] received, process restarting

(interesting enough, no "Restart pause" here)

gert
-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             g...@greenie.muc.de
fax: +49-89-35655025                        g...@net.informatik.tu-muenchen.de

Attachment: signature.asc
Description: PGP signature

Reply via email to