ACK. Reviewed the patch before - performance impact is not high (compared to exec()'ing netsh.exe), and I can see the argument that the approach I suggested would be changing too many different places to be more "clean". Compile-tested, not run.
Your patch has been applied to the master and release/2.3 branch (bugfix). commit 6aa4c9091300f62fae0bf7a9198de0edd2d8b7c7 (master) commit 13f3526a9b05bed63c50c93c5903b0cde0dcc7f4 (release/2.3) Author: Selva Nair List-Post: [email protected] Date: Mon Jun 13 22:34:49 2016 -0400 Promptly close the netcmd_semaphore handle after use Signed-off-by: Selva Nair <[email protected]> Acked-by: Gert Doering <[email protected]> Message-Id: <[email protected]> URL: http://article.gmane.org/gmane.network.openvpn.devel/11919 Signed-off-by: Gert Doering <[email protected]> -- kind regards, Gert Doering
