Hi, On Mon, Jul 11, 2016 at 10:50 AM, Arne Schwabe <a...@rfc2549.org> wrote:
> Before the connect-retry change to do exponential backup this was not > necessary > since the time was fixed. With the exponential backoff the UI needs either > to > implement its own exponential backoff mechansim or needs a way of knowing > the > value of OpenVPN internal mechansim. > This is required only if the GUI keeps "hold on" between SIGUSR1 restarts --- windows GUI does "hold off" before hold release so hold will happen only the first time after a SIGHUP. > --- > doc/management-notes.txt | 7 +++++-- > src/openvpn/init.c | 17 ++++++++++------- > src/openvpn/manage.c | 8 ++++++-- > src/openvpn/manage.h | 2 +- > 4 files changed, 22 insertions(+), 12 deletions(-) > > diff --git a/doc/management-notes.txt b/doc/management-notes.txt > index f68f3db..eb857ab 100644 > --- a/doc/management-notes.txt > +++ b/doc/management-notes.txt > @@ -168,9 +168,12 @@ be reset by restarts. > > OpenVPN will indicate that it is in a hold state by > sending a real-time notification to the management > -client: > +client, the parameter indicates how long OpenVPN would > +wait without UI (as influenced connect-retry exponential > +backoff. The UI need to wait for releasing the hold if it > +wants similar behavior: > FWIW, some typos: influenced -> influenced by need --> needs and a missing closing parenthesis? > > - >HOLD:Waiting for hold release > + >HOLD:Waiting for hold release:10 > Windows GUI is fine with this, but potentially a UI may break with this change depending on how it parses the line. Just a warning to UI maintainers.. Rest of the code looks good. Selva
