Il 24/09/2016 09:32, Илья Шипицин ha scritto: > can we merge it ? > > 2016-09-17 16:17 GMT+05:00 Steffan Karger <stef...@karger.me > <mailto:stef...@karger.me>>: > > Hi, > > On 17 September 2016 at 12:54, Ilya Shipitsin <chipits...@gmail.com > <mailto:chipits...@gmail.com>> wrote: > > --- > > .travis.yml | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/.travis.yml b/.travis.yml > > index 452c48e..369db97 100644 > > --- a/.travis.yml > > +++ b/.travis.yml > > @@ -51,10 +51,6 @@ matrix: > > os: osx > > osx_image: xcode7.3 > > compiler: clang > > - allow_failures: > > - - env: SSLLIB="openssl" EXTRA_CONFIG="--disable-crypto" > > - os: linux > > - compiler: clang > > exclude: > > - compiler: gcc > > > > -- > > 2.5.5 > > Thanks. The patch is good, so ACK. > > But the commit messages should describe why this change is needed. In > this case: > > Previously, 'make test' failed for --disable-crypto builds. Since > that is not fixed, we should no longer accept --disable-crypto builds > to fail 'make test' on travis. > > Could you please include such descriptions in future patches? > > -Steffan > > > > > ------------------------------------------------------------------------------ > > > > _______________________________________________ > Openvpn-devel mailing list > Openvpn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openvpn-devel >
All the pieces (ACK, fixed commit message) seem to be present. Maybe it would be easiest to fix the commit message just before the push: --- Enable "--disable-crypto" build configuration Previously, 'make test' failed for --disable-crypto builds. Since that is not fixed, we should no longer accept --disable-crypto builds to fail 'make test' on travis. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock ------------------------------------------------------------------------------ _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
