On 26-10-16 14:40, Antonio Quartulli wrote: > I was planning to do the rest of the refactoring in a second patch. > > At this point I think it would make sense to reject this patch and wait for a > full patchset set where I will: > > 1) "fix" every inline option to be sure that we don't carry around bogus > settings > 2) switch any *_inline field to bool > 3) refactor the code to avoid strcmp()
Yes, consider your patch rejected ;) For me the proposed changes would be fine as a single patch - this is strongly related and not very complex. In particular 2 and 3 should probably go together. -Steffan
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ The Command Line: Reinvented for Modern Developers Did the resurgence of CLI tooling catch you by surprise? Reconnect with the command line and become more productive. Learn the new .NET and ASP.NET CLI. Get your free copy! http://sdm.link/telerik
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
