Hi, On 05-11-16 11:34, Илья Шипицин wrote: > > 2016-11-05 13:08 GMT+05:00 Steffan Karger <stef...@karger.me > <mailto:stef...@karger.me>>: > > On 05-11-16 06:52, Илья Шипицин wrote: > > I'm geting "build only" travis-ci mingw cross compile config > > and I came to idea that I do not understand why "tap-windows.h" must be > > downloaded separately > > > > 1) if we use some functions, we should include prototypes. it is not > > very common to download prototypes from different location > > When using external dependencies it is *not* a best practice to include > the headers of that dependency (or even worse, binaries) into your own > project repository. I haven't seen any decent C project do that. We > wouldn't include the OpenSSL, mbed TLS or even libc headers either, > would we? > > we include cmocka as git submodule. > if such an approach is acceptable, we can use another submodule (to > tap-windows repo)
Yes, which I'm still wondering about whether that was the right choice. Using configure might have made more sense. Either way, although I don't agree with your suggested approach, I do see that building (and particularly, cross compiling) isn't easy, and that it would be nice to improve on that. A different approach (which I use internally for OpenVPN-NL) is to create a build repository with build scripts and all the required dependencies as submodules. It might make sense to do something like that for openvpn-build? (This works nicely for us internally, but I'm not so sure that would work as well for openvpn-build.) -Steffan ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
