Il 11/11/2016 09:58, Gert Doering ha scritto: > Hi, > > On Fri, Nov 11, 2016 at 12:25:49AM +0000, debbie10t wrote: >> On 08/11/16 13:50, sam...@openvpn.net wrote: >>> From: Samuli Seppänen <sam...@openvpn.net> >> >>> + $cmd -b $bytes -C 20 -p 250 -q $FPING_EXTRA_ARGS $targetlist >>> >>$LOGDIR/$SUF:fping.out 2>&1 >> >> This allows $FPING_EXTRA_ARGS to take precedence over previous arguments >> >> eg: $FPING_EXTRA_ARGS = "-C 1000 -p 1000 -i 1000" > > Right, which was the point of "v2" :-) - it's a good way to shoot your > own foot, but this is an "expert mode knob". > >> This does not: >> $cmd $FPING_EXTRA_ARGS -b $bytes -C 20 -p 250 -q $targetlist >> $LOGDIR/$SUF:fping.out 2>&1 > > Right, which was v1. > > gert
In any case, thanks for the review to both of you! -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
