Hi,
On Sun, Nov 13, 2016 at 02:50:43PM +0100, Gert Doering wrote:
> ACK. Brilliant approach to "make the compiler happy" that is *increasing*
> code readability, not making it worse.
>
> Reviewed ("STARE AT CODE!"), client tests on linux and freebsd, server
> tests on linux.
>
> Your patch has been applied to the master branch.
This had interesting fallout. I expected some linux/BSD issues (due
to generally different socket things), but instead the buildbots had
massive issues on all "older" systems - namely, NetBSD 5.1, OpenBSD 4.9,
CentOS 6, FreeBSD 9.3, FreeBSD 7.4.
The core of the issue seems to be this one:
gcc -DHAVE_CONFIG_H -I. -I../../../openvpn/src/openvpn -I../.. -I../../include
-I../../../openvpn/include -I../../../openvpn/src/compat -g -O2
-std=c99 -MT error.o -MD -MP -MF .deps/error.Tpo -c -o error.o
../../../openvpn/src/openvpn/error.c
In file included from ../../../openvpn/src/openvpn/manage.h:33,
from ../../../openvpn/src/openvpn/options.h:40,
from ../../../openvpn/src/openvpn/ssl.h:43,
from ../../../openvpn/src/openvpn/ps.h:32,
from ../../../openvpn/src/openvpn/error.c:43:
../../../openvpn/src/openvpn/mroute.h:99: warning: declaration does not declare
anything
../../../openvpn/src/openvpn/mroute.h:103: error: 'struct mroute_addr' has no
member named 'v4'
../../../openvpn/src/openvpn/mroute.h:103: error: 'struct mroute_addr' has no
member named 'v4'
../../../openvpn/src/openvpn/mroute.h:103: error: bit-field
'__error_if_negative' width not an integer constant
../../../openvpn/src/openvpn/mroute.h:106: error: 'struct mroute_addr' has no
member named 'v6'
../../../openvpn/src/openvpn/mroute.h:106: error: 'struct mroute_addr' has no
member named 'v6'
which translates to
- the new union most not by anonymous ("does not declare anything")
- if I name it, like "a", the warning in line 99 goes away
- but then, all references need to be added that name
"addr->a.v4.addr"
etc.
While I could live with abandoning FreeBSD 7.4, we need to keep supporting
at least FreeBSD 9.3 - so, any ideas how to deal with that?
MinGW builds fail because there is no "in_port_t" declaration, which is
something configure should be able to fix for us.
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
