Hi, On Thu, Nov 03, 2016 at 07:21:54PM +0100, David Sommerseth wrote: > This is a bit scary. I have nothing to complain about in the patch, > so I feel like I'm not seeing the large neon-pink elephant in the room.
I've reviewed the code and found a few nag bits, so you're just not
critical enough :-)
None of the nag bits are relevant enough to NAK the code - so, combined
with your detailed review of the SSL library side...
> I can definitely give this one a Feature-ACK. I can also support a
> full ACK too if one more developer does a thorough code review.
... I think this is good enough. So, ACK.
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
