Found by the clang static analyzer: the state_change variable is set,
but never read afterwards. This code has been like this since 2005,
makes sense without setting state_change to true, and has worked fine
for the past 11 years.
Signed-off-by: Steffan Karger <steffan.kar...@fox-it.com>
---
src/openvpn/ssl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c
index e0cf1c5..991515b 100644
--- a/src/openvpn/ssl.c
+++ b/src/openvpn/ssl.c
@@ -2809,7 +2809,6 @@ tls_process (struct tls_multi *multi,
RELIABLE_ACK_SIZE, false);
*to_link = buf;
active = true;
- state_change = true;
dmsg (D_TLS_DEBUG, "Dedicated ACK -> TCP/UDP");
}
#endif
--
2.7.4
------------------------------------------------------------------------------
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
